Skip to content

Commit

Permalink
SPI: spi_txx9: Fix bit rate calculation
Browse files Browse the repository at this point in the history
TXx9 SPI bit rate is calculated by:
        fBR = (spi-baseclk) / (n + 1)
Fix calculation of min_speed_hz, max_speed_hz and n.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Atsushi Nemoto authored and Ralf Baechle committed Dec 2, 2009
1 parent 56f3f55 commit dbf763a
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions drivers/spi/spi_txx9.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@


#define SPI_FIFO_SIZE 4
#define SPI_MAX_DIVIDER 0xff /* Max. value for SPCR1.SER */
#define SPI_MIN_DIVIDER 1 /* Min. value for SPCR1.SER */

#define TXx9_SPMCR 0x00
#define TXx9_SPCR0 0x04
Expand Down Expand Up @@ -193,11 +195,8 @@ static void txx9spi_work_one(struct txx9spi *c, struct spi_message *m)

if (prev_speed_hz != speed_hz
|| prev_bits_per_word != bits_per_word) {
u32 n = (c->baseclk + speed_hz - 1) / speed_hz;
if (n < 1)
n = 1;
else if (n > 0xff)
n = 0xff;
int n = DIV_ROUND_UP(c->baseclk, speed_hz) - 1;
n = clamp(n, SPI_MIN_DIVIDER, SPI_MAX_DIVIDER);
/* enter config mode */
txx9spi_wr(c, mcr | TXx9_SPMCR_CONFIG | TXx9_SPMCR_BCLR,
TXx9_SPMCR);
Expand Down Expand Up @@ -370,8 +369,8 @@ static int __init txx9spi_probe(struct platform_device *dev)
goto exit;
}
c->baseclk = clk_get_rate(c->clk);
c->min_speed_hz = (c->baseclk + 0xff - 1) / 0xff;
c->max_speed_hz = c->baseclk;
c->min_speed_hz = DIV_ROUND_UP(c->baseclk, SPI_MAX_DIVIDER + 1);
c->max_speed_hz = c->baseclk / (SPI_MIN_DIVIDER + 1);

res = platform_get_resource(dev, IORESOURCE_MEM, 0);
if (!res)
Expand Down

0 comments on commit dbf763a

Please sign in to comment.