Skip to content

Commit

Permalink
[S390] Program check in diag 210 under 31 bit
Browse files Browse the repository at this point in the history
If a virtual address is passed to the diag210 function under 31 bit, we get a
programming exception, since diag 210 only works with physical addresses. To
fix this, the content of the diag210 data structure is copied to a local
structure and the physical address of that structure is passed to diagnose 210.

Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Michael Holzheu authored and Martin Schwidefsky committed Jul 10, 2007
1 parent 8a88367 commit dc41233
Showing 1 changed file with 7 additions and 15 deletions.
22 changes: 7 additions & 15 deletions drivers/s390/cio/device_id.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
/*
* diag210 is used under VM to get information about a virtual device
*/
#ifdef CONFIG_64BIT
int
diag210(struct diag210 * addr)
{
Expand All @@ -43,6 +42,7 @@ diag210(struct diag210 * addr)
spin_lock_irqsave(&diag210_lock, flags);
diag210_tmp = *addr;

#ifdef CONFIG_64BIT
asm volatile(
" lhi %0,-1\n"
" sam31\n"
Expand All @@ -51,31 +51,23 @@ diag210(struct diag210 * addr)
" srl %0,28\n"
"1: sam64\n"
EX_TABLE(0b,1b)
: "=&d" (ccode) : "a" (__pa(&diag210_tmp)) : "cc", "memory");

*addr = diag210_tmp;
spin_unlock_irqrestore(&diag210_lock, flags);

return ccode;
}
: "=&d" (ccode) : "a" (&diag210_tmp) : "cc", "memory");
#else
int
diag210(struct diag210 * addr)
{
int ccode;

asm volatile(
" lhi %0,-1\n"
" diag %1,0,0x210\n"
"0: ipm %0\n"
" srl %0,28\n"
"1:\n"
EX_TABLE(0b,1b)
: "=&d" (ccode) : "a" (__pa(addr)) : "cc", "memory");
: "=&d" (ccode) : "a" (&diag210_tmp) : "cc", "memory");
#endif

*addr = diag210_tmp;
spin_unlock_irqrestore(&diag210_lock, flags);

return ccode;
}
#endif

/*
* Input :
Expand Down

0 comments on commit dc41233

Please sign in to comment.