Skip to content

Commit

Permalink
[MIPS] Fix 32-bit kernel by replacing 64-bit-only code.
Browse files Browse the repository at this point in the history
dclz() expects its 64-bit argument being passed as a single register
but on 32-bit kernels it'll actually be in a register pair.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Ralf Baechle committed Sep 27, 2006
1 parent 73b76c7 commit dc41fb4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
19 changes: 2 additions & 17 deletions arch/mips/sibyte/bcm1480/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -469,21 +469,6 @@ void bcm1480_kgdb_interrupt(struct pt_regs *regs)

#endif /* CONFIG_KGDB */

static inline int dclz(unsigned long long x)
{
int lz;

__asm__ (
" .set push \n"
" .set mips64 \n"
" dclz %0, %1 \n"
" .set pop \n"
: "=r" (lz)
: "r" (x));

return lz;
}

extern void bcm1480_timer_interrupt(struct pt_regs *regs);
extern void bcm1480_mailbox_interrupt(struct pt_regs *regs);
extern void bcm1480_kgdb_interrupt(struct pt_regs *regs);
Expand Down Expand Up @@ -536,9 +521,9 @@ asmlinkage void plat_irq_dispatch(struct pt_regs *regs)

if (mask_h) {
if (mask_h ^ 1)
do_IRQ(63 - dclz(mask_h), regs);
do_IRQ(fls64(mask_h) - 1, regs);
else
do_IRQ(127 - dclz(mask_l), regs);
do_IRQ(63 + fls64(mask_l), regs);
}
}
}
17 changes: 1 addition & 16 deletions arch/mips/sibyte/sb1250/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,21 +419,6 @@ static void sb1250_kgdb_interrupt(struct pt_regs *regs)

#endif /* CONFIG_KGDB */

static inline int dclz(unsigned long long x)
{
int lz;

__asm__ (
" .set push \n"
" .set mips64 \n"
" dclz %0, %1 \n"
" .set pop \n"
: "=r" (lz)
: "r" (x));

return lz;
}

extern void sb1250_timer_interrupt(struct pt_regs *regs);
extern void sb1250_mailbox_interrupt(struct pt_regs *regs);
extern void sb1250_kgdb_interrupt(struct pt_regs *regs);
Expand Down Expand Up @@ -490,6 +475,6 @@ asmlinkage void plat_irq_dispatch(struct pt_regs *regs)
mask = __raw_readq(IOADDR(A_IMR_REGISTER(smp_processor_id(),
R_IMR_INTERRUPT_STATUS_BASE)));
if (mask)
do_IRQ(63 - dclz(mask), regs);
do_IRQ(fls64(mask) - 1, regs);
}
}

0 comments on commit dc41fb4

Please sign in to comment.