Skip to content

Commit

Permalink
V4L/DVB (11074): au0828: fix i2c enumeration bug
Browse files Browse the repository at this point in the history
There was a bug where enumerating the i2c for devices would result in false
positives.  The root of the issue was the scanning was using SMBUS_QUICK
messages, which are zero length write requests (which our i2c adapter
implementation didn't handle).  Because we never strobed any bytes onto the
bus, the status register would still contain the value from the previous
request.

Thanks to Michael Krufky <mkrufky@linuxtv.org> and Steven Toth
<stoth@linuxtv.org> for providing sample hardware, engineering level support,
and testing.

Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Devin Heitmueller authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 5a5a4e1 commit dc8685b
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions drivers/media/video/au0828/au0828-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,24 @@ static int i2c_sendbytes(struct i2c_adapter *i2c_adap,

dprintk(4, "SEND: %02x\n", msg->addr);

/* Deal with i2c_scan */
if (msg->len == 0) {
/* The analog tuner detection code makes use of the SMBUS_QUICK
message (which involves a zero length i2c write). To avoid
checking the status register when we didn't strobe out any
actual bytes to the bus, just do a read check. This is
consistent with how I saw i2c device checking done in the
USB trace of the Windows driver */
au0828_write(dev, REG_200, 0x20);
if (!i2c_wait_done(i2c_adap))
return -EIO;

if (i2c_wait_read_ack(i2c_adap))
return -EIO;

return 0;
}

for (i = 0; i < msg->len;) {

dprintk(4, " %02x\n", msg->buf[i]);
Expand Down

0 comments on commit dc8685b

Please sign in to comment.