Skip to content

Commit

Permalink
[PATCH] x86_64: use select for GART_IOMMU to enable AGP
Browse files Browse the repository at this point in the history
The AGP default doesn't work well with other selects, so use a select for
GART_IOMMU as well.  Remove a redundant default for SWIOTLB as well.

Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@muc.de>
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Dave Airlie <airlied@linux.ie>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Roman Zippel authored and Linus Torvalds committed Jun 22, 2006
1 parent 4f3865f commit dcc1a66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions arch/x86_64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ config GART_IOMMU
bool "K8 GART IOMMU support"
default y
select SWIOTLB
select AGP
depends on PCI
help
Support for hardware IOMMU in AMD's Opteron/Athlon64 Processors
Expand All @@ -401,11 +402,9 @@ config GART_IOMMU
northbridge and a software emulation used on other systems without
hardware IOMMU. If unsure, say Y.

# need this always enabled with GART_IOMMU for the VIA workaround
# need this always selected by GART_IOMMU for the VIA workaround
config SWIOTLB
bool
default y
depends on GART_IOMMU

config X86_MCE
bool "Machine check support" if EMBEDDED
Expand Down
3 changes: 1 addition & 2 deletions drivers/char/agp/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
config AGP
tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
tristate "/dev/agpgart (AGP Support)"
depends on ALPHA || IA64 || PPC || X86
default y if GART_IOMMU
---help---
AGP (Accelerated Graphics Port) is a bus system mainly used to
connect graphics cards to the rest of the system.
Expand Down

0 comments on commit dcc1a66

Please sign in to comment.