Skip to content

Commit

Permalink
mmc: msm_sdcc: Handle error cases in probe
Browse files Browse the repository at this point in the history
Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Signed-off-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
  • Loading branch information
Sahitya Tummala authored and Chris Ball committed Oct 26, 2011
1 parent e91957e commit dce7c75
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions drivers/mmc/host/msm_sdcc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ msmsdcc_probe(struct platform_device *pdev)
host->base = ioremap(memres->start, PAGE_SIZE);
if (!host->base) {
ret = -ENOMEM;
goto out;
goto host_free;
}

host->cmd_irqres = cmd_irqres;
Expand All @@ -1230,13 +1230,15 @@ msmsdcc_probe(struct platform_device *pdev)
/*
* Setup DMA
*/
msmsdcc_init_dma(host);
ret = msmsdcc_init_dma(host);
if (ret)
goto ioremap_free;

/* Get our clocks */
host->pclk = clk_get(&pdev->dev, "sdc_pclk");
if (IS_ERR(host->pclk)) {
ret = PTR_ERR(host->pclk);
goto host_free;
goto dma_free;
}

host->clk = clk_get(&pdev->dev, "sdc_clk");
Expand Down Expand Up @@ -1377,6 +1379,12 @@ msmsdcc_probe(struct platform_device *pdev)
clk_put(host->clk);
pclk_put:
clk_put(host->pclk);
dma_free:
dma_free_coherent(NULL, sizeof(struct msmsdcc_nc_dmadata),
host->dma.nc, host->dma.nc_busaddr);
ioremap_free:
tasklet_kill(&host->dma_tlet);
iounmap(host->base);
host_free:
mmc_free_host(mmc);
out:
Expand Down

0 comments on commit dce7c75

Please sign in to comment.