Skip to content

Commit

Permalink
[media] m5mols: Add JPEG compression quality control
Browse files Browse the repository at this point in the history
Add JPEG compression quality control for snapshot capture.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed May 14, 2012
1 parent 50d3f93 commit dd9c471
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 2 additions & 0 deletions drivers/media/video/m5mols/m5mols.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ struct m5mols_version {
* @zoom: zoom control
* @wdr: wide dynamic range control
* @stabilization: image stabilization control
* @jpeg_quality: JPEG compression quality control
* @ver: information of the version
* @cap: the capture mode attributes
* @power: current sensor's power status
Expand Down Expand Up @@ -213,6 +214,7 @@ struct m5mols_info {
struct v4l2_ctrl *zoom;
struct v4l2_ctrl *wdr;
struct v4l2_ctrl *stabilization;
struct v4l2_ctrl *jpeg_quality;

struct m5mols_version ver;
struct m5mols_capture cap;
Expand Down
10 changes: 8 additions & 2 deletions drivers/media/video/m5mols/m5mols_controls.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,10 @@ static int m5mols_s_ctrl(struct v4l2_ctrl *ctrl)
case V4L2_CID_IMAGE_STABILIZATION:
ret = m5mols_set_stabilization(info, ctrl->val);
break;

case V4L2_CID_JPEG_COMPRESSION_QUALITY:
ret = m5mols_write(sd, CAPP_JPEG_RATIO, ctrl->val);
break;
}

if (ret == 0 && info->mode != last_mode)
Expand Down Expand Up @@ -530,8 +534,7 @@ int m5mols_init_controls(struct v4l2_subdev *sd)
return ret;

zoom_step = is_manufacturer(info, REG_SAMSUNG_OPTICS) ? 31 : 1;

v4l2_ctrl_handler_init(&info->handle, 6);
v4l2_ctrl_handler_init(&info->handle, 20);

info->auto_wb = v4l2_ctrl_new_std_menu(&info->handle,
&m5mols_ctrl_ops, V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE,
Expand Down Expand Up @@ -579,6 +582,9 @@ int m5mols_init_controls(struct v4l2_subdev *sd)
info->stabilization = v4l2_ctrl_new_std(&info->handle, &m5mols_ctrl_ops,
V4L2_CID_IMAGE_STABILIZATION, 0, 1, 1, 0);

info->jpeg_quality = v4l2_ctrl_new_std(&info->handle, &m5mols_ctrl_ops,
V4L2_CID_JPEG_COMPRESSION_QUALITY, 1, 100, 1, 80);

if (info->handle.error) {
int ret = info->handle.error;
v4l2_err(sd, "Failed to initialize controls: %d\n", ret);
Expand Down
1 change: 1 addition & 0 deletions drivers/media/video/m5mols/m5mols_reg.h
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@
#define REG_JPEG 0x10

#define CAPP_MAIN_IMAGE_SIZE I2C_REG(CAT_CAPT_PARM, 0x01, 1)
#define CAPP_JPEG_RATIO I2C_REG(CAT_CAPT_PARM, 0x17, 1)

#define CAPP_MCC_MODE I2C_REG(CAT_CAPT_PARM, 0x1d, 1)
#define REG_MCC_OFF 0x00
Expand Down

0 comments on commit dd9c471

Please sign in to comment.