Skip to content

Commit

Permalink
mISDN: get_free_devid() failure ignored
Browse files Browse the repository at this point in the history
dev->id is unsigned so a get_free_devid() error is ignored.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Roel Kluin authored and David S. Miller committed May 25, 2009
1 parent db9bb63 commit ddacd14
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/isdn/mISDN/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ get_free_devid(void)
if (!test_and_set_bit(i, (u_long *)&device_ids))
break;
if (i > MAX_DEVICE_ID)
return -1;
return -EBUSY;
return i;
}

Expand All @@ -224,10 +224,10 @@ mISDN_register_device(struct mISDNdevice *dev,
{
int err;

dev->id = get_free_devid();
err = -EBUSY;
if (dev->id < 0)
err = get_free_devid();
if (err < 0)
goto error1;
dev->id = err;

device_initialize(&dev->dev);
if (name && name[0])
Expand Down

0 comments on commit ddacd14

Please sign in to comment.