Skip to content

Commit

Permalink
[IA64] Fix missing iounmap in error path in cyclone.c
Browse files Browse the repository at this point in the history
By moving the iounmap up above the test, it takes place whether the test
succeeds or fails.

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Julia Lawall authored and Tony Luck committed Sep 23, 2010
1 parent 383f9f1 commit ddad53e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/ia64/kernel/cyclone.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ int __init init_cyclone_clock(void)
return -ENODEV;
}
base = readq(reg);
iounmap(reg);
if(!base){
printk(KERN_ERR "Summit chipset: Could not find valid CBAR"
" value.\n");
use_cyclone = 0;
return -ENODEV;
}
iounmap(reg);

/* setup PMCC */
offset = (base + CYCLONE_PMCC_OFFSET);
Expand Down

0 comments on commit ddad53e

Please sign in to comment.