Skip to content

Commit

Permalink
m68k/math-emu: unsigned issue, 'unsigned long' will never be less tha…
Browse files Browse the repository at this point in the history
…n zero

'oldmant.m32[1]' is 'unsigned long' which can never be '< 0', and the
original author wanted to check whether the highest bit is set.

So make the bit test explicit (which is better than casting from 'unsigned
long' to 'long').

The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
  arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
  • Loading branch information
Chen Gang authored and Geert Uytterhoeven committed Jun 24, 2013
1 parent 220921a commit ddc2fc2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/m68k/math-emu/fp_arith.c
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
return;
break;
case 0x401e:
if (!(oldmant.m32[1] >= 0))
if (oldmant.m32[1] & 0x80000000)
return;
if (oldmant.m32[0] & 1)
break;
Expand Down

0 comments on commit ddc2fc2

Please sign in to comment.