Skip to content

Commit

Permalink
USB: Fix PS3 USB shutdown problems
Browse files Browse the repository at this point in the history
Add ehci_shutdown() or ohci_shutdown() calls to the USB
PS3 bus glue.  ehci_shutdown() and ohci_shutdown() do some
controller specific cleanups not done by usb_remove_hcd().

Fixes errors on shutdown or reboot similar to these:

  ps3-ehci-driver sb_07: HC died; cleaning up
  irq 51: nobody cared (try booting with the "irqpoll" option)

Related bugzilla reports:

  http://bugzilla.kernel.org/show_bug.cgi?id=11819
  http://bugzilla.terrasoftsolutions.com/show_bug.cgi?id=317

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Geoff Levand authored and Greg Kroah-Hartman committed Nov 13, 2008
1 parent 8010e06 commit ddcb01f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions drivers/usb/host/ehci-ps3.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ static int ps3_ehci_remove(struct ps3_system_bus_device *dev)

tmp = hcd->irq;

ehci_shutdown(hcd);
usb_remove_hcd(hcd);

ps3_system_bus_set_driver_data(dev, NULL);
Expand Down
3 changes: 2 additions & 1 deletion drivers/usb/host/ohci-ps3.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ static int ps3_ohci_probe(struct ps3_system_bus_device *dev)
return result;
}

static int ps3_ohci_remove (struct ps3_system_bus_device *dev)
static int ps3_ohci_remove(struct ps3_system_bus_device *dev)
{
unsigned int tmp;
struct usb_hcd *hcd =
Expand All @@ -205,6 +205,7 @@ static int ps3_ohci_remove (struct ps3_system_bus_device *dev)

tmp = hcd->irq;

ohci_shutdown(hcd);
usb_remove_hcd(hcd);

ps3_system_bus_set_driver_data(dev, NULL);
Expand Down

0 comments on commit ddcb01f

Please sign in to comment.