Skip to content

Commit

Permalink
KVM: x86 emulator: add ad_mask static inline
Browse files Browse the repository at this point in the history
Replaces open-coded mask calculation in macros.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
  • Loading branch information
Harvey Harrison authored and Avi Kivity committed Apr 27, 2008
1 parent 790c73f commit ddcb288
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions arch/x86/kvm/x86_emulate.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,15 @@ static u16 group2_table[] = {
(_type)_x; \
})

static inline unsigned long ad_mask(struct decode_cache *c)
{
return (1UL << (c->ad_bytes << 3)) - 1;
}

/* Access/update address held in a register, based on addressing mode. */
#define address_mask(reg) \
((c->ad_bytes == sizeof(unsigned long)) ? \
(reg) : ((reg) & ((1UL << (c->ad_bytes << 3)) - 1)))
(reg) : ((reg) & ad_mask(c)))
#define register_address(base, reg) \
((base) + address_mask(reg))
#define register_address_increment(reg, inc) \
Expand All @@ -494,9 +499,9 @@ static u16 group2_table[] = {
(reg) += _inc; \
else \
(reg) = ((reg) & \
~((1UL << (c->ad_bytes << 3)) - 1)) | \
~ad_mask(c)) | \
(((reg) + _inc) & \
((1UL << (c->ad_bytes << 3)) - 1)); \
ad_mask(c)); \
} while (0)

#define JMP_REL(rel) \
Expand Down

0 comments on commit ddcb288

Please sign in to comment.