Skip to content

Commit

Permalink
[XFS] fix compile on 32 bit systems
Browse files Browse the repository at this point in the history
The recent compat patches make xfs_file.c include xfs_ioctl32.h unconditional,
which breaks the build on 32 bit systems which don't have the various compat
defintions.

Remove the include and move the defintion of xfs_file_compat_ioctl to
xfs_ioctl.h so that we can avoid including all the compat defintions in
xfs_file.c

Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Lachlan McIlroy committed Dec 4, 2008
1 parent e5d412f commit ddcd856
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fs/xfs/linux-2.6/xfs_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
#include "xfs_inode.h"
#include "xfs_error.h"
#include "xfs_rw.h"
#include "xfs_ioctl32.h"
#include "xfs_vnodeops.h"
#include "xfs_da_btree.h"
#include "xfs_ioctl.h"

#include <linux/dcache.h>
#include <linux/smp_lock.h>
Expand Down
12 changes: 12 additions & 0 deletions fs/xfs/linux-2.6/xfs_ioctl.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,16 @@ xfs_attrmulti_attr_remove(
char *name,
__uint32_t flags);

extern long
xfs_file_compat_ioctl(
struct file *file,
unsigned int cmd,
unsigned long arg);

extern long
xfs_file_compat_ioctl_invis(
struct file *file,
unsigned int cmd,
unsigned long arg);

#endif
3 changes: 0 additions & 3 deletions fs/xfs/linux-2.6/xfs_ioctl32.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@

#include <linux/compat.h>

extern long xfs_file_compat_ioctl(struct file *, unsigned, unsigned long);
extern long xfs_file_compat_invis_ioctl(struct file *, unsigned, unsigned long);

/*
* on 32-bit arches, ioctl argument structures may have different sizes
* and/or alignment. We define compat structures which match the
Expand Down

0 comments on commit ddcd856

Please sign in to comment.