Skip to content

Commit

Permalink
be2net: use "if (!foo)" test style
Browse files Browse the repository at this point in the history
Replace "if (foo == NULL)" statements with "if (!foo)" to be consistent
across the driver.

Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kalesh AP authored and David S. Miller committed Jul 17, 2014
1 parent b99f803 commit ddf1169
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/net/ethernet/emulex/benet/be_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2034,7 +2034,7 @@ static void be_rx_cq_clean(struct be_rx_obj *rxo)
*/
for (;;) {
rxcp = be_rx_compl_get(rxo);
if (rxcp == NULL) {
if (!rxcp) {
if (lancer_chip(adapter))
break;

Expand Down Expand Up @@ -2941,7 +2941,7 @@ static int be_setup_wol(struct be_adapter *adapter, bool enable)
cmd.size = sizeof(struct be_cmd_req_acpi_wol_magic_config);
cmd.va = dma_zalloc_coherent(&adapter->pdev->dev, cmd.size, &cmd.dma,
GFP_KERNEL);
if (cmd.va == NULL)
if (!cmd.va)
return -ENOMEM;

if (enable) {
Expand Down Expand Up @@ -4133,7 +4133,7 @@ static int lancer_fw_download(struct be_adapter *adapter,
static int be_get_ufi_type(struct be_adapter *adapter,
struct flash_file_hdr_g3 *fhdr)
{
if (fhdr == NULL)
if (!fhdr)
goto be_get_ufi_exit;

if (skyhawk_chip(adapter) && fhdr->build[0] == '4')
Expand Down Expand Up @@ -4475,12 +4475,12 @@ static int be_map_pci_bars(struct be_adapter *adapter)

if (BEx_chip(adapter) && be_physfn(adapter)) {
adapter->csr = pci_iomap(adapter->pdev, 2, 0);
if (adapter->csr == NULL)
if (!adapter->csr)
return -ENOMEM;
}

addr = pci_iomap(adapter->pdev, db_bar(adapter), 0);
if (addr == NULL)
if (!addr)
goto pci_map_err;
adapter->db = addr;

Expand Down Expand Up @@ -4543,7 +4543,7 @@ static int be_ctrl_init(struct be_adapter *adapter)
rx_filter->va = dma_zalloc_coherent(&adapter->pdev->dev,
rx_filter->size, &rx_filter->dma,
GFP_KERNEL);
if (rx_filter->va == NULL) {
if (!rx_filter->va) {
status = -ENOMEM;
goto free_mbox;
}
Expand Down Expand Up @@ -4592,7 +4592,7 @@ static int be_stats_init(struct be_adapter *adapter)

cmd->va = dma_zalloc_coherent(&adapter->pdev->dev, cmd->size, &cmd->dma,
GFP_KERNEL);
if (cmd->va == NULL)
if (!cmd->va)
return -ENOMEM;
return 0;
}
Expand Down Expand Up @@ -4814,7 +4814,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
pci_set_master(pdev);

netdev = alloc_etherdev_mqs(sizeof(*adapter), MAX_TX_QS, MAX_RX_QS);
if (netdev == NULL) {
if (!netdev) {
status = -ENOMEM;
goto rel_reg;
}
Expand Down

0 comments on commit ddf1169

Please sign in to comment.