Skip to content

Commit

Permalink
NFS: Set key construction data for the legacy upcall
Browse files Browse the repository at this point in the history
This prevents a null pointer dereference when
nfs_idmap_complete_pipe_upcall_locked() calls complete_request_key().

Fixes a regression caused by commit 0cac120 (NFSv4: Ensure that
idmap_pipe_downcall sanity-checks the downcall data).

Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Bryan Schumaker authored and Trond Myklebust committed Oct 2, 2012
1 parent fd48357 commit ddfc4e1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/nfs/idmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,7 @@ static int nfs_idmap_legacy_upcall(struct key_construction *cons,
msg = &data->pipe_msg;
im = &data->idmap_msg;
data->idmap = idmap;
data->key_cons = cons;

ret = nfs_idmap_prepare_message(key->description, idmap, im, msg);
if (ret < 0)
Expand Down

0 comments on commit ddfc4e1

Please sign in to comment.