Skip to content

Commit

Permalink
synclink: remove bogus 'no change' termios optimisation from synclink…
Browse files Browse the repository at this point in the history
… drivers

Again this check is wrong now, and un-needed

Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Alan Cox authored and Linus Torvalds committed Jul 16, 2007
1 parent 3542612 commit de1764a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 24 deletions.
8 changes: 0 additions & 8 deletions drivers/char/synclink.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@ typedef struct _DMABUFFERENTRY

#define IO_PIN_SHUTDOWN_LIMIT 100

#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))

struct _input_signal_events {
int ri_up;
int ri_down;
Expand Down Expand Up @@ -3064,12 +3062,6 @@ static void mgsl_set_termios(struct tty_struct *tty, struct ktermios *old_termio
printk("%s(%d):mgsl_set_termios %s\n", __FILE__,__LINE__,
tty->driver->name );

/* just return if nothing has changed */
if ((tty->termios->c_cflag == old_termios->c_cflag)
&& (RELEVANT_IFLAG(tty->termios->c_iflag)
== RELEVANT_IFLAG(old_termios->c_iflag)))
return;

mgsl_change_params(info);

/* Handle transition to B0 status */
Expand Down
8 changes: 0 additions & 8 deletions drivers/char/synclink_gt.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ MODULE_PARM_DESC(dosyncppp, "Enable synchronous net device, 0=disable 1=enable")
/*
* tty support and callbacks
*/
#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))

static struct tty_driver *serial_driver;

static int open(struct tty_struct *tty, struct file * filp);
Expand Down Expand Up @@ -823,12 +821,6 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)

DBGINFO(("%s set_termios\n", tty->driver->name));

/* just return if nothing has changed */
if ((tty->termios->c_cflag == old_termios->c_cflag)
&& (RELEVANT_IFLAG(tty->termios->c_iflag)
== RELEVANT_IFLAG(old_termios->c_iflag)))
return;

change_params(info);

/* Handle transition to B0 status */
Expand Down
8 changes: 0 additions & 8 deletions drivers/char/synclinkmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ typedef struct _SCADESC_EX

#define IO_PIN_SHUTDOWN_LIMIT 100

#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))

struct _input_signal_events {
int ri_up;
int ri_down;
Expand Down Expand Up @@ -927,12 +925,6 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
printk("%s(%d):%s set_termios()\n", __FILE__,__LINE__,
tty->driver->name );

/* just return if nothing has changed */
if ((tty->termios->c_cflag == old_termios->c_cflag)
&& (RELEVANT_IFLAG(tty->termios->c_iflag)
== RELEVANT_IFLAG(old_termios->c_iflag)))
return;

change_params(info);

/* Handle transition to B0 status */
Expand Down

0 comments on commit de1764a

Please sign in to comment.