Skip to content

Commit

Permalink
mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference
Browse files Browse the repository at this point in the history
fix for:
net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison
expression (different address spaces)

remove incorrect rcu_dereference possibly left over from
earlier revisions of the code.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Roopa Prabhu authored and David S. Miller committed Jul 22, 2015
1 parent 70c9bb8 commit de18547
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mpls/mpls_iptunnel.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ int mpls_output(struct sock *sk, struct sk_buff *skb)
skb_orphan(skb);

/* Find the output device */
out_dev = rcu_dereference(dst->dev);
out_dev = dst->dev;
if (!mpls_output_possible(out_dev) ||
!lwtstate || skb_warn_if_lro(skb))
goto drop;
Expand Down

0 comments on commit de18547

Please sign in to comment.