Skip to content

Commit

Permalink
[PATCH] fix black/white-only svideo input in vpx3220 decoder
Browse files Browse the repository at this point in the history
Fix the fact that the svideo input will only give input in black/white in
some circumstances.  Reason is that in the PCI controller driver (zr36067),
after setting input, we reset norm, which overwrites the input register
with the default.  This patch makes it always set the correct value for the
input when changing norm.

Signed-off-by: Ronald S. Bultje <rbultje@ronald.bitfreak.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Ronald S. Bultje authored and Linus Torvalds committed Oct 17, 2005
1 parent 9b3acc2 commit de21eb6
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/media/video/vpx3220.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,12 @@ vpx3220_command (struct i2c_client *client,
case DECODER_SET_NORM:
{
int *iarg = arg, data;
int temp_input;

/* Here we back up the input selection because it gets
overwritten when we fill the registers with the
choosen video norm */
temp_input = vpx3220_fp_read(client, 0xf2);

dprintk(1, KERN_DEBUG "%s: DECODER_SET_NORM %d\n",
I2C_NAME(client), *iarg);
Expand Down Expand Up @@ -447,6 +453,10 @@ vpx3220_command (struct i2c_client *client,

}
decoder->norm = *iarg;

/* And here we set the backed up video input again */
vpx3220_fp_write(client, 0xf2, temp_input | 0x0010);
udelay(10);
}
break;

Expand Down

0 comments on commit de21eb6

Please sign in to comment.