Skip to content

Commit

Permalink
sched/completion: Remove unnecessary ->wait.lock serialization when r…
Browse files Browse the repository at this point in the history
…eading completion state

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1421467534-22834-1-git-send-email-der.herr@hofr.at
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Nicholas Mc Guire authored and Ingo Molnar committed Feb 4, 2015
1 parent 51587bc commit de30ec4
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions kernel/sched/completion.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,13 +288,6 @@ EXPORT_SYMBOL(try_wait_for_completion);
*/
bool completion_done(struct completion *x)
{
unsigned long flags;
int ret = 1;

spin_lock_irqsave(&x->wait.lock, flags);
if (!x->done)
ret = 0;
spin_unlock_irqrestore(&x->wait.lock, flags);
return ret;
return !!ACCESS_ONCE(x->done);
}
EXPORT_SYMBOL(completion_done);

0 comments on commit de30ec4

Please sign in to comment.