-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
percpu: don't implicitly include slab.h from percpu.h
percpu.h has always been including slab.h to get k[mz]alloc/free() for UP inline implementation. percpu.h being used by very low level headers including module.h and sched.h, this meant that a lot files unintentionally got slab.h inclusion. Lee Schermerhorn was trying to make topology.h use percpu.h and got bitten by this implicit inclusion. The right thing to do is break this ultimately unnecessary dependency. The previous patch added explicit inclusion of either gfp.h or slab.h to the source files using them. This patch updates percpu.h such that slab.h is no longer included from percpu.h. Signed-off-by: Tejun Heo <tj@kernel.org> Reviewed-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
- Loading branch information
Tejun Heo
committed
Mar 30, 2010
1 parent
ea5a9f0
commit de380b5
Showing
3 changed files
with
40 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
* mm/percpu_up.c - dummy percpu memory allocator implementation for UP | ||
*/ | ||
|
||
#include <linux/module.h> | ||
#include <linux/percpu.h> | ||
#include <linux/slab.h> | ||
|
||
void __percpu *__alloc_percpu(size_t size, size_t align) | ||
{ | ||
/* | ||
* Can't easily make larger alignment work with kmalloc. WARN | ||
* on it. Larger alignment should only be used for module | ||
* percpu sections on SMP for which this path isn't used. | ||
*/ | ||
WARN_ON_ONCE(align > SMP_CACHE_BYTES); | ||
return kzalloc(size, GFP_KERNEL); | ||
} | ||
EXPORT_SYMBOL_GPL(__alloc_percpu); | ||
|
||
void free_percpu(void __percpu *p) | ||
{ | ||
kfree(p); | ||
} | ||
EXPORT_SYMBOL_GPL(free_percpu); | ||
|
||
phys_addr_t per_cpu_ptr_to_phys(void *addr) | ||
{ | ||
return __pa(addr); | ||
} |