Skip to content

Commit

Permalink
af_packet: use sizeof instead of constant in spkt_device
Browse files Browse the repository at this point in the history
This small patch removes access to the last element of the spkt_device
array through a constant. Instead, it is accessed by sizeof() to respect
possible changes in if_packet.h.

Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
danborkmann@iogearbox.net authored and David S. Miller committed Jun 11, 2012
1 parent 55afaba commit de74e92
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/packet/af_packet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,7 @@ static int packet_sendmsg_spkt(struct kiocb *iocb, struct socket *sock,
* Find the device first to size check it
*/

saddr->spkt_device[13] = 0;
saddr->spkt_device[sizeof(saddr->spkt_device) - 1] = 0;
retry:
rcu_read_lock();
dev = dev_get_by_name_rcu(sock_net(sk), saddr->spkt_device);
Expand Down

0 comments on commit de74e92

Please sign in to comment.