Skip to content

Commit

Permalink
V4L/DVB (12199): remove redundant tests on unsigned
Browse files Browse the repository at this point in the history
input, inp and i are unsigned. When negative they are wrapped and caught by the
other test.

Cc: Andy Walls <awalls@radix.net>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Roel Kluin authored and Mauro Carvalho Chehab committed Sep 12, 2009
1 parent ce27cd3 commit de81c3c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/media/dvb/ttpci/av7110_v4l.c
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int input)
if (!av7110->analog_tuner_flags)
return 0;

if (input < 0 || input >= 4)
if (input >= 4)
return -EINVAL;

av7110->current_input = input;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx18/cx18-ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ int cx18_s_input(struct file *file, void *fh, unsigned int inp)
if (ret)
return ret;

if (inp < 0 || inp >= cx->nof_inputs)
if (inp >= cx->nof_inputs)
return -EINVAL;

if (inp == cx->active_input) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/saa7134/saa7134-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,7 @@ static int saa7134_s_input(struct file *file, void *priv, unsigned int i)
if (0 != err)
return err;

if (i < 0 || i >= SAA7134_INPUT_MAX)
if (i >= SAA7134_INPUT_MAX)
return -EINVAL;
if (NULL == card_in(dev, i).name)
return -EINVAL;
Expand Down

0 comments on commit de81c3c

Please sign in to comment.