Skip to content

Commit

Permalink
x86: move pci-nommu's dma_mask check to common code
Browse files Browse the repository at this point in the history
The check to see if dev->dma_mask is NULL in pci-nommu is more
appropriate for dma_alloc_coherent().

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
FUJITA Tomonori authored and Ingo Molnar committed Sep 8, 2008
1 parent 3a80b6a commit de9f521
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 0 additions & 3 deletions arch/x86/kernel/pci-nommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ nommu_alloc_coherent(struct device *hwdev, size_t size,
int node;
struct page *page;

if (hwdev->dma_mask == NULL)
return NULL;

gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
gfp |= __GFP_ZERO;

Expand Down
3 changes: 3 additions & 0 deletions include/asm-x86/dma-mapping.h
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle,
gfp |= GFP_DMA;
}

if (!dev->dma_mask)
return NULL;

if (ops->alloc_coherent)
return ops->alloc_coherent(dev, size,
dma_handle, gfp);
Expand Down

0 comments on commit de9f521

Please sign in to comment.