Skip to content

Commit

Permalink
dpt_i20: BKL pushdown
Browse files Browse the repository at this point in the history
Add lock_kernel() calls to adpt_open()

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
  • Loading branch information
Jonathan Corbet committed Jun 20, 2008
1 parent 9aaf20c commit dea3f66
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/scsi/dpt_i2o.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ MODULE_DESCRIPTION("Adaptec I2O RAID Driver");
#include <linux/kernel.h> /* for printk */
#include <linux/sched.h>
#include <linux/reboot.h>
#include <linux/smp_lock.h>
#include <linux/spinlock.h>
#include <linux/dma-mapping.h>

Expand Down Expand Up @@ -1727,10 +1728,12 @@ static int adpt_open(struct inode *inode, struct file *file)
int minor;
adpt_hba* pHba;

lock_kernel();
//TODO check for root access
//
minor = iminor(inode);
if (minor >= hba_count) {
unlock_kernel();
return -ENXIO;
}
mutex_lock(&adpt_configuration_lock);
Expand All @@ -1741,6 +1744,7 @@ static int adpt_open(struct inode *inode, struct file *file)
}
if (pHba == NULL) {
mutex_unlock(&adpt_configuration_lock);
unlock_kernel();
return -ENXIO;
}

Expand All @@ -1751,6 +1755,7 @@ static int adpt_open(struct inode *inode, struct file *file)

pHba->in_use = 1;
mutex_unlock(&adpt_configuration_lock);
unlock_kernel();

return 0;
}
Expand Down

0 comments on commit dea3f66

Please sign in to comment.