Skip to content

Commit

Permalink
[CIFS] Remove over-indented code in find_unc().
Browse files Browse the repository at this point in the history
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Steve French committed May 6, 2008
1 parent a815752 commit dea570e
Showing 1 changed file with 31 additions and 33 deletions.
64 changes: 31 additions & 33 deletions fs/cifs/connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -1362,45 +1362,43 @@ find_unc(__be32 new_target_ip_addr, char *uncName, char *userName)
{
struct list_head *tmp;
struct cifsTconInfo *tcon;
__be32 old_ip;

read_lock(&GlobalSMBSeslock);

list_for_each(tmp, &GlobalTreeConnectionList) {
cFYI(1, ("Next tcon"));
tcon = list_entry(tmp, struct cifsTconInfo, cifsConnectionList);
if (tcon->ses) {
if (tcon->ses->server) {
cFYI(1,
("old ip addr: %x == new ip %x ?",
tcon->ses->server->addr.sockAddr.sin_addr.
s_addr, new_target_ip_addr));
if (tcon->ses->server->addr.sockAddr.sin_addr.
s_addr == new_target_ip_addr) {
/* BB lock tcon, server and tcp session and increment use count here? */
/* found a match on the TCP session */
/* BB check if reconnection needed */
cFYI(1,
("IP match, old UNC: %s new: %s",
tcon->treeName, uncName));
if (strncmp
(tcon->treeName, uncName,
MAX_TREE_SIZE) == 0) {
cFYI(1,
("and old usr: %s new: %s",
tcon->treeName, uncName));
if (strncmp
(tcon->ses->userName,
userName,
MAX_USERNAME_SIZE) == 0) {
read_unlock(&GlobalSMBSeslock);
/* matched smb session
(user name */
return tcon;
}
}
}
}
}
if (!tcon->ses || !tcon->ses->server)
continue;

old_ip = tcon->ses->server->addr.sockAddr.sin_addr.s_addr;
cFYI(1, ("old ip addr: %x == new ip %x ?",
old_ip, new_target_ip_addr));

if (old_ip != new_target_ip_addr)
continue;

/* BB lock tcon, server, tcp session and increment use count? */
/* found a match on the TCP session */
/* BB check if reconnection needed */
cFYI(1, ("IP match, old UNC: %s new: %s",
tcon->treeName, uncName));

if (strncmp(tcon->treeName, uncName, MAX_TREE_SIZE))
continue;

cFYI(1, ("and old usr: %s new: %s",
tcon->treeName, uncName));

if (strncmp(tcon->ses->userName, userName, MAX_USERNAME_SIZE))
continue;

/* matched smb session (user name) */
read_unlock(&GlobalSMBSeslock);
return tcon;
}

read_unlock(&GlobalSMBSeslock);
return NULL;
}
Expand Down

0 comments on commit dea570e

Please sign in to comment.