Skip to content

Commit

Permalink
EDAC, MCE: Warn about LS MCEs on F14h
Browse files Browse the repository at this point in the history
F14h CPUs do not generate LS MCEs so exit early and warn the user in
case this path is ever hit that something else might be going haywire.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
  • Loading branch information
Borislav Petkov authored and Borislav Petkov committed Oct 21, 2010
1 parent dd53bce commit ded5062
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions drivers/edac/mce_amd.c
Original file line number Diff line number Diff line change
Expand Up @@ -339,19 +339,27 @@ static void amd_decode_bu_mce(struct mce *m)

static void amd_decode_ls_mce(struct mce *m)
{
u32 ec = m->status & 0xffff;
u32 xec = (m->status >> 16) & 0xf;
u16 ec = m->status & 0xffff;
u8 xec = (m->status >> 16) & 0xf;

if (boot_cpu_data.x86 == 0x14) {
pr_emerg("You shouldn't be seeing an LS MCE on this cpu family,"
" please report on LKML.\n");
return;
}

pr_emerg(HW_ERR "Load Store Error");

if (xec == 0x0) {
u8 rrrr = (ec >> 4) & 0xf;
u8 r4 = (ec >> 4) & 0xf;

if (!BUS_ERROR(ec) || (rrrr != 0x3 && rrrr != 0x4))
if (!BUS_ERROR(ec) || (r4 != R4_DRD && r4 != R4_DWR))
goto wrong_ls_mce;

pr_cont(" during %s.\n", RRRR_MSG(ec));
}
} else
goto wrong_ls_mce;

return;

wrong_ls_mce:
Expand Down

0 comments on commit ded5062

Please sign in to comment.