Skip to content

Commit

Permalink
Btrfs: fix check_path_shared so it returns the right value
Browse files Browse the repository at this point in the history
When running xfstests 224 I kept getting ENOSPC when trying to remove the files,
and this is because we were returning ret from check_path_shared while it was
uninitalized, which isn't right.  Fix this to return 0 properly, and now
xfstests 224 doesn't freak out when it tries to clean itself up.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
  • Loading branch information
Josef Bacik authored and Chris Mason committed Jan 28, 2011
1 parent abd30bb commit dedefd7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions fs/btrfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -2718,9 +2718,10 @@ static int check_path_shared(struct btrfs_root *root,
struct extent_buffer *eb;
int level;
u64 refs = 1;
int uninitialized_var(ret);

for (level = 0; level < BTRFS_MAX_LEVEL; level++) {
int ret;

if (!path->nodes[level])
break;
eb = path->nodes[level];
Expand All @@ -2731,7 +2732,7 @@ static int check_path_shared(struct btrfs_root *root,
if (refs > 1)
return 1;
}
return ret; /* XXX callers? */
return 0;
}

/*
Expand Down

0 comments on commit dedefd7

Please sign in to comment.