Skip to content

Commit

Permalink
writeback: remove smp_mb(), it's not needed with list_add_tail_rcu()
Browse files Browse the repository at this point in the history
list_add_tail_rcu contains required barriers.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Nick Piggin authored and Jens Axboe committed Sep 16, 2009
1 parent 49db041 commit deed62e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/fs-writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ static void bdi_queue_work(struct backing_dev_info *bdi, struct bdi_work *work)
BUG_ON(!bdi->wb_cnt);

/*
* Make sure stores are seen before it appears on the list
* list_add_tail_rcu() contains the necessary barriers to
* make sure the above stores are seen before the item is
* noticed on the list
*/
smp_mb();

spin_lock(&bdi->wb_lock);
list_add_tail_rcu(&work->list, &bdi->work_list);
spin_unlock(&bdi->wb_lock);
Expand Down

0 comments on commit deed62e

Please sign in to comment.