Skip to content

Commit

Permalink
ipv4: Elide use of rt->rt_dst in ip_forward()
Browse files Browse the repository at this point in the history
No matter what kind of header mangling occurs due to IP options
processing, rt->rt_dst will always equal iph->daddr in the packet.

So we can safely use iph->daddr instead of rt->rt_dst here.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed May 12, 2011
1 parent c30883b commit def5768
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/ip_forward.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ int ip_forward(struct sk_buff *skb)

rt = skb_rtable(skb);

if (opt->is_strictroute && rt->rt_dst != rt->rt_gateway)
if (opt->is_strictroute && iph->daddr != rt->rt_gateway)
goto sr_failed;

if (unlikely(skb->len > dst_mtu(&rt->dst) && !skb_is_gso(skb) &&
Expand Down

0 comments on commit def5768

Please sign in to comment.