Skip to content

Commit

Permalink
ACPI_NUMA: fix HP IA64 simulator issue with extended memory domain
Browse files Browse the repository at this point in the history
ACPI 3.0 incorporated the SRAT spec, upping the table version to 2,
and extending the size of the proximity domain from 1-byte to 4-bytes.
This extension was into a reserved field that firmware should
set to 0, but the HP simulator had non-zero values there
resulting in unexpected huge numbers.

So mask the domain down to 8-bits for now.
A more general fix will be to check the table version
supplied by firmware and get paranoid about reserved fields.

Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alexey Starikovskiy authored and Len Brown committed Feb 3, 2007
1 parent 45eded8 commit defad23
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/ia64/kernel/acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,8 @@ static int get_memory_proximity_domain(struct acpi_srat_mem_affinity *ma)
int pxm;

pxm = ma->proximity_domain;
if (ia64_platform_is("sn2"))
pxm += ma->reserved << 8;
if (!ia64_platform_is("sn2"))
pxm &= 0xff;

return pxm;
}
Expand Down

0 comments on commit defad23

Please sign in to comment.