attach_recursive_mnt() needs to hold vfsmount_lock over set_mnt_shared()

race in mnt_flags update Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
git-mirror · Jan 16, 2010 · df1a1ad · df1a1ad
1 parent 8ad08d8
commit df1a1ad
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/fs/namespace.c b/fs/namespace.c
@@ -1354,12 +1354,12 @@ static int attach_recursive_mnt(struct vfsmount *source_mnt,
 	if (err)
 		goto out_cleanup_ids;
 
+	spin_lock(&vfsmount_lock);
+
 	if (IS_MNT_SHARED(dest_mnt)) {
 		for (p = source_mnt; p; p = next_mnt(p, source_mnt))
 			set_mnt_shared(p);
 	}
-
-	spin_lock(&vfsmount_lock);
 	if (parent_path) {
 		detach_mnt(source_mnt, parent_path);
 		attach_mnt(source_mnt, path);