Skip to content

Commit

Permalink
x86, mce, cmci: remove incorrect __cpuinit/__cpuexit annotations
Browse files Browse the repository at this point in the history
Impact: Bug fix on UP

The MCE code is reinitialized from resume, so we can't use
__cpuinit/__cpuexit for most of the code.  Remove those annotations
for anything downstream of mce_init().

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
H. Peter Anvin committed Feb 24, 2009
1 parent 88ccbed commit df20e2e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions arch/x86/kernel/cpu/mcheck/mce_intel_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static DEFINE_SPINLOCK(cmci_discover_lock);

#define CMCI_THRESHOLD 1

static __cpuinit int cmci_supported(int *banks)
static int cmci_supported(int *banks)
{
u64 cap;

Expand Down Expand Up @@ -147,7 +147,7 @@ static void print_update(char *type, int *hdr, int num)
* on this CPU. Use the algorithm recommended in the SDM to discover shared
* banks.
*/
static __cpuinit void cmci_discover(int banks, int boot)
static void cmci_discover(int banks, int boot)
{
unsigned long *owned = (void *)&__get_cpu_var(mce_banks_owned);
int hdr = 0;
Expand Down Expand Up @@ -192,7 +192,7 @@ static __cpuinit void cmci_discover(int banks, int boot)
* Just in case we missed an event during initialization check
* all the CMCI owned banks.
*/
__cpuinit void cmci_recheck(void)
void cmci_recheck(void)
{
unsigned long flags;
int banks;
Expand All @@ -208,7 +208,7 @@ __cpuinit void cmci_recheck(void)
* Disable CMCI on this CPU for all banks it owns when it goes down.
* This allows other CPUs to claim the banks on rediscovery.
*/
void __cpuexit cmci_clear(void)
void cmci_clear(void)
{
int i;
int banks;
Expand All @@ -233,7 +233,7 @@ void __cpuexit cmci_clear(void)
* After a CPU went down cycle through all the others and rediscover
* Must run in process context.
*/
void __cpuexit cmci_rediscover(int dying)
void cmci_rediscover(int dying)
{
int banks;
int cpu;
Expand Down

0 comments on commit df20e2e

Please sign in to comment.