Skip to content

Commit

Permalink
libata-acpi: allow _GTF on SATA, but disable on PATA for now
Browse files Browse the repository at this point in the history
The ACPI specification states, and BIOS implementations depend on,
_STM being called before _GTF.

SATA does this, but PATA does not.  So for now, simply
prevent execution of _GTF on PATA devices.  Longer term we
should implement ACPI support for PATA devices in libata.

Signed-off-by: Kristen Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Kristen Accardi authored and Len Brown committed Mar 9, 2007
1 parent 908e0a8 commit df33c77
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/ata/libata-acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,13 @@ int ata_acpi_exec_tfs(struct ata_port *ap)

if (noacpi)
return 0;
/*
* TBD - implement PATA support. For now,
* we should not run GTF on PATA devices since some
* PATA require execution of GTM/STM before GTF.
*/
if (!(ap->cbl == ATA_CBL_SATA))
return 0;

for (ix = 0; ix < ATA_MAX_DEVICES; ix++) {
if (!ata_dev_enabled(&ap->device[ix]))
Expand Down

0 comments on commit df33c77

Please sign in to comment.