Skip to content

Commit

Permalink
ACPI: relax BAD_MADT_ENTRY check to allow LSAPIC variable length stri…
Browse files Browse the repository at this point in the history
…ng UIDs

ACPI 3.0 appended a variable length UID string to the LAPIC structure
as part of support for > 256 processors.  So the BAD_MADT_ENTRY() sanity
check can no longer compare for equality with a fixed structure length.

Signed-off-by: Alexey Y Starikovskiy <alexey.y.starikovskiy@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Starikovskiy, Alexey Y authored and Len Brown committed Aug 18, 2006
1 parent d68909f commit df6fd31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ static inline int gsi_irq_sharing(int gsi) { return gsi; }

#define BAD_MADT_ENTRY(entry, end) ( \
(!entry) || (unsigned long)entry + sizeof(*entry) > end || \
((acpi_table_entry_header *)entry)->length != sizeof(*entry))
((acpi_table_entry_header *)entry)->length < sizeof(*entry))

#define PREFIX "ACPI: "

Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@

#define BAD_MADT_ENTRY(entry, end) ( \
(!entry) || (unsigned long)entry + sizeof(*entry) > end || \
((acpi_table_entry_header *)entry)->length != sizeof(*entry))
((acpi_table_entry_header *)entry)->length < sizeof(*entry))

#define PREFIX "ACPI: "

Expand Down

0 comments on commit df6fd31

Please sign in to comment.