Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 55233
b: refs/heads/master
c: b03670e
h: refs/heads/master
i:
  55231: 7b6a5c1
v: v3
  • Loading branch information
Christof Schmitt authored and James Bottomley committed May 8, 2007
1 parent 2465884 commit df7d7af
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 29 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2135be5f24ee6620ea6f2a594087d51b6a67ce7e
refs/heads/master: b03670e5277224d1166cb5e4f610fc388186b065
34 changes: 6 additions & 28 deletions trunk/drivers/s390/scsi/zfcp_qdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ zfcp_qdio_request_handler(struct ccw_device *ccw_device,
/**
* zfcp_qdio_reqid_check - checks for valid reqids or unsolicited status
*/
static int zfcp_qdio_reqid_check(struct zfcp_adapter *adapter,
unsigned long req_id)
static void zfcp_qdio_reqid_check(struct zfcp_adapter *adapter,
unsigned long req_id)
{
struct zfcp_fsf_req *fsf_req;
unsigned long flags;
Expand All @@ -298,9 +298,7 @@ static int zfcp_qdio_reqid_check(struct zfcp_adapter *adapter,

if (!fsf_req) {
spin_unlock_irqrestore(&adapter->req_list_lock, flags);
ZFCP_LOG_NORMAL("error: unknown request id (%ld).\n", req_id);
zfcp_erp_adapter_reopen(adapter, 0);
return -EINVAL;
panic("error: unknown request id (%ld).\n", req_id);
}

zfcp_reqlist_remove(adapter, req_id);
Expand All @@ -309,8 +307,6 @@ static int zfcp_qdio_reqid_check(struct zfcp_adapter *adapter,

/* finish the FSF request */
zfcp_fsf_req_complete(fsf_req);

return 0;
}

/*
Expand Down Expand Up @@ -374,27 +370,9 @@ zfcp_qdio_response_handler(struct ccw_device *ccw_device,

/* look for QDIO request identifiers in SB */
buffere = &buffer->element[buffere_index];
retval = zfcp_qdio_reqid_check(adapter,
(unsigned long) buffere->addr);

if (retval) {
ZFCP_LOG_NORMAL("bug: unexpected inbound "
"packet on adapter %s "
"(reqid=0x%lx, "
"first_element=%d, "
"elements_processed=%d)\n",
zfcp_get_busid_by_adapter(adapter),
(unsigned long) buffere->addr,
first_element,
elements_processed);
ZFCP_LOG_NORMAL("hex dump of inbound buffer "
"at address %p "
"(buffer_index=%d, "
"buffere_index=%d)\n", buffer,
buffer_index, buffere_index);
ZFCP_HEX_DUMP(ZFCP_LOG_LEVEL_NORMAL,
(char *) buffer, SBAL_SIZE);
}
zfcp_qdio_reqid_check(adapter,
(unsigned long) buffere->addr);

/*
* A single used SBALE per inbound SBALE has been
* implemented by QDIO so far. Hope they will
Expand Down

0 comments on commit df7d7af

Please sign in to comment.