Skip to content

Commit

Permalink
IA64: fix VT-d dma_mapping_error
Browse files Browse the repository at this point in the history
dma_mapping_error is used to see if dma_map_single and dma_map_page
succeed. IA64 VT-d dma_mapping_error always says that dma_map_single
is successful even though it could fail. Note that X86 VT-d works
properly in this regard.

This patch fixes IA64 VT-d dma_mapping_error by adding VT-d's own
dma_mapping_error() that works for both X86_64 and IA64. VT-d uses
zero as an error dma address so VT-d's dma_mapping_error returns 1 if
a passed dma address is zero (as x86's VT-d dma_mapping_error does
now).

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
FUJITA Tomonori authored and Ingo Molnar committed Jan 29, 2009
1 parent 97d9800 commit dfb805e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 0 additions & 6 deletions arch/ia64/kernel/pci-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ int iommu_dma_supported(struct device *dev, u64 mask)
}
EXPORT_SYMBOL(iommu_dma_supported);

static int vtd_dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
{
return 0;
}

void __init pci_iommu_alloc(void)
{
dma_ops = &intel_dma_ops;
Expand All @@ -113,7 +108,6 @@ void __init pci_iommu_alloc(void)
dma_ops->sync_single_for_device = machvec_dma_sync_single;
dma_ops->sync_sg_for_device = machvec_dma_sync_sg;
dma_ops->dma_supported = iommu_dma_supported;
dma_ops->mapping_error = vtd_dma_mapping_error;

/*
* The order of these functions is important for
Expand Down
6 changes: 6 additions & 0 deletions drivers/pci/intel-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -2581,13 +2581,19 @@ int intel_map_sg(struct device *hwdev, struct scatterlist *sglist, int nelems,
return nelems;
}

static int intel_mapping_error(struct device *dev, dma_addr_t dma_addr)
{
return !dma_addr;
}

struct dma_map_ops intel_dma_ops = {
.alloc_coherent = intel_alloc_coherent,
.free_coherent = intel_free_coherent,
.map_sg = intel_map_sg,
.unmap_sg = intel_unmap_sg,
.map_page = intel_map_page,
.unmap_page = intel_unmap_page,
.mapping_error = intel_mapping_error,
};

static inline int iommu_domain_cache_init(void)
Expand Down

0 comments on commit dfb805e

Please sign in to comment.