Skip to content

Commit

Permalink
[PATCH] device-mapper: let freeze_bdev return error
Browse files Browse the repository at this point in the history
Allow freeze_bdev() to return an error.

Signed-Off-By: Alasdair G Kergon <agk@redhat.com>
From: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Alasdair G Kergon authored and Linus Torvalds committed May 5, 2005
1 parent 3dcee80 commit dfbe03f
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -991,22 +991,38 @@ int dm_swap_table(struct mapped_device *md, struct dm_table *table)
*/
static int __lock_fs(struct mapped_device *md)
{
int error = -ENOMEM;

if (test_and_set_bit(DMF_FS_LOCKED, &md->flags))
return 0;

md->frozen_bdev = bdget_disk(md->disk, 0);
if (!md->frozen_bdev) {
DMWARN("bdget failed in __lock_fs");
return -ENOMEM;
goto out;
}

WARN_ON(md->frozen_sb);

md->frozen_sb = freeze_bdev(md->frozen_bdev);
if (IS_ERR(md->frozen_sb)) {
error = PTR_ERR(md->frozen_sb);
goto out_bdput;
}

/* don't bdput right now, we don't want the bdev
* to go away while it is locked. We'll bdput
* in __unlock_fs
*/
return 0;

out_bdput:
bdput(md->frozen_bdev);
md->frozen_sb = NULL;
md->frozen_bdev = NULL;
out:
clear_bit(DMF_FS_LOCKED, &md->flags);
return error;
}

static void __unlock_fs(struct mapped_device *md)
Expand Down

0 comments on commit dfbe03f

Please sign in to comment.