Skip to content

Commit

Permalink
Fix another dereference before null check warning
Browse files Browse the repository at this point in the history
null tcon is not possible in these paths so
remove confusing null check

Reported by Coverity (CID 728519)

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
  • Loading branch information
Steve French committed Apr 1, 2015
1 parent 8b7a454 commit dfebe40
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/cifs/smb2pdu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,

rc = SendReceive2(xid, ses, iov, 1, &resp_buftype, 0);

if ((rc != 0) && tcon)
if (rc != 0)
cifs_stats_fail_inc(tcon, SMB2_FLUSH_HE);

free_rsp_buf(resp_buftype, iov[0].iov_base);
Expand Down

0 comments on commit dfebe40

Please sign in to comment.