Skip to content

Commit

Permalink
PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation
Browse files Browse the repository at this point in the history
decode_hpp() looks up hotplug PCI parameters from ACPI and saves them
in the acpiphp_bridge structure.  These parameters (in bridge->hpp) are
only used by the acpiphp_set_hpp_values() -> program_hpp() path.  In
that path, we always call decode_hpp() before program_hpp(), so there's
no need to do it in init_bridge_misc().

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Reviewed-by: Alex Chiang <achiang@hp.com>
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Bjorn Helgaas authored and Jesse Barnes committed Sep 15, 2009
1 parent 4b77b0a commit dffb4bb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/pci/hotplug/acpiphp_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
{
acpi_status status;

/* decode ACPI 2.0 _HPP (hot plug parameters) */
decode_hpp(bridge);

/* must be added to the list prior to calling register_slot */
list_add(&bridge->list, &bridge_list);

Expand Down

0 comments on commit dffb4bb

Please sign in to comment.