Skip to content

Commit

Permalink
[PATCH] drivers/net/sk98lin/: possible cleanups
Browse files Browse the repository at this point in the history
This patch contains the following possible cleanups:
- make needlessly global functions static
- remove unused code

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Adrian Bunk authored and Jeff Garzik committed Jan 17, 2006
1 parent 2664b25 commit e03d72b
Show file tree
Hide file tree
Showing 17 changed files with 40 additions and 1,108 deletions.
48 changes: 0 additions & 48 deletions drivers/net/sk98lin/h/skaddr.h
Original file line number Diff line number Diff line change
Expand Up @@ -236,54 +236,18 @@ extern int SkAddrMcClear(
SK_U32 PortNumber,
int Flags);

extern int SkAddrXmacMcClear(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
int Flags);

extern int SkAddrGmacMcClear(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
int Flags);

extern int SkAddrMcAdd(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
SK_MAC_ADDR *pMc,
int Flags);

extern int SkAddrXmacMcAdd(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
SK_MAC_ADDR *pMc,
int Flags);

extern int SkAddrGmacMcAdd(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
SK_MAC_ADDR *pMc,
int Flags);

extern int SkAddrMcUpdate(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber);

extern int SkAddrXmacMcUpdate(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber);

extern int SkAddrGmacMcUpdate(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber);

extern int SkAddrOverride(
SK_AC *pAC,
SK_IOC IoC,
Expand All @@ -297,18 +261,6 @@ extern int SkAddrPromiscuousChange(
SK_U32 PortNumber,
int NewPromMode);

extern int SkAddrXmacPromiscuousChange(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
int NewPromMode);

extern int SkAddrGmacPromiscuousChange(
SK_AC *pAC,
SK_IOC IoC,
SK_U32 PortNumber,
int NewPromMode);

#ifndef SK_SLIM
extern int SkAddrSwap(
SK_AC *pAC,
Expand Down
6 changes: 0 additions & 6 deletions drivers/net/sk98lin/h/skcsum.h
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,6 @@ extern SKCS_STATUS SkCsGetReceiveInfo(
unsigned Checksum2,
int NetNumber);

extern void SkCsGetSendInfo(
SK_AC *pAc,
void *pIpHeader,
SKCS_PACKET_INFO *pPacketInfo,
int NetNumber);

extern void SkCsSetReceiveFlags(
SK_AC *pAc,
unsigned ReceiveFlags,
Expand Down
56 changes: 0 additions & 56 deletions drivers/net/sk98lin/h/skgeinit.h
Original file line number Diff line number Diff line change
Expand Up @@ -464,12 +464,6 @@ typedef struct s_GeInit {
/*
* public functions in skgeinit.c
*/
extern void SkGePollRxD(
SK_AC *pAC,
SK_IOC IoC,
int Port,
SK_BOOL PollRxD);

extern void SkGePollTxD(
SK_AC *pAC,
SK_IOC IoC,
Expand Down Expand Up @@ -522,10 +516,6 @@ extern void SkGeXmitLED(
int Led,
int Mode);

extern void SkGeInitRamIface(
SK_AC *pAC,
SK_IOC IoC);

extern int SkGeInitAssignRamToQueues(
SK_AC *pAC,
int ActivePort,
Expand All @@ -549,11 +539,6 @@ extern void SkMacHardRst(
SK_IOC IoC,
int Port);

extern void SkMacClearRst(
SK_AC *pAC,
SK_IOC IoC,
int Port);

extern void SkXmInitMac(
SK_AC *pAC,
SK_IOC IoC,
Expand All @@ -580,11 +565,6 @@ extern void SkMacFlushTxFifo(
SK_IOC IoC,
int Port);

extern void SkMacFlushRxFifo(
SK_AC *pAC,
SK_IOC IoC,
int Port);

extern void SkMacIrq(
SK_AC *pAC,
SK_IOC IoC,
Expand All @@ -601,12 +581,6 @@ extern void SkMacAutoNegLipaPhy(
int Port,
SK_U16 IStatus);

extern void SkMacSetRxTxEn(
SK_AC *pAC,
SK_IOC IoC,
int Port,
int Para);

extern int SkMacRxTxEnable(
SK_AC *pAC,
SK_IOC IoC,
Expand Down Expand Up @@ -659,16 +633,6 @@ extern void SkXmClrExactAddr(
int StartNum,
int StopNum);

extern void SkXmInitDupMd(
SK_AC *pAC,
SK_IOC IoC,
int Port);

extern void SkXmInitPauseMd(
SK_AC *pAC,
SK_IOC IoC,
int Port);

extern void SkXmAutoNegLipaXmac(
SK_AC *pAC,
SK_IOC IoC,
Expand Down Expand Up @@ -729,17 +693,6 @@ extern int SkGmCableDiagStatus(
int Port,
SK_BOOL StartTest);

extern int SkGmEnterLowPowerMode(
SK_AC *pAC,
SK_IOC IoC,
int Port,
SK_U8 Mode);

extern int SkGmLeaveLowPowerMode(
SK_AC *pAC,
SK_IOC IoC,
int Port);

#ifdef SK_DIAG
extern void SkGePhyRead(
SK_AC *pAC,
Expand Down Expand Up @@ -782,7 +735,6 @@ extern void SkXmSendCont(
/*
* public functions in skgeinit.c
*/
extern void SkGePollRxD();
extern void SkGePollTxD();
extern void SkGeYellowLED();
extern int SkGeCfgSync();
Expand All @@ -792,7 +744,6 @@ extern int SkGeInit();
extern void SkGeDeInit();
extern int SkGeInitPort();
extern void SkGeXmitLED();
extern void SkGeInitRamIface();
extern int SkGeInitAssignRamToQueues();

/*
Expand All @@ -801,27 +752,22 @@ extern int SkGeInitAssignRamToQueues();
extern void SkMacRxTxDisable();
extern void SkMacSoftRst();
extern void SkMacHardRst();
extern void SkMacClearRst();
extern void SkMacInitPhy();
extern int SkMacRxTxEnable();
extern void SkMacPromiscMode();
extern void SkMacHashing();
extern void SkMacIrqDisable();
extern void SkMacFlushTxFifo();
extern void SkMacFlushRxFifo();
extern void SkMacIrq();
extern int SkMacAutoNegDone();
extern void SkMacAutoNegLipaPhy();
extern void SkMacSetRxTxEn();
extern void SkXmInitMac();
extern void SkXmPhyRead();
extern void SkXmPhyWrite();
extern void SkGmInitMac();
extern void SkGmPhyRead();
extern void SkGmPhyWrite();
extern void SkXmClrExactAddr();
extern void SkXmInitDupMd();
extern void SkXmInitPauseMd();
extern void SkXmAutoNegLipaXmac();
extern int SkXmUpdateStats();
extern int SkGmUpdateStats();
Expand All @@ -832,8 +778,6 @@ extern int SkGmResetCounter();
extern int SkXmOverflowStatus();
extern int SkGmOverflowStatus();
extern int SkGmCableDiagStatus();
extern int SkGmEnterLowPowerMode();
extern int SkGmLeaveLowPowerMode();

#ifdef SK_DIAG
extern void SkGePhyRead();
Expand Down
4 changes: 0 additions & 4 deletions drivers/net/sk98lin/h/skgepnmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -946,10 +946,6 @@ typedef struct s_PnmiData {
* Function prototypes
*/
extern int SkPnmiInit(SK_AC *pAC, SK_IOC IoC, int Level);
extern int SkPnmiGetVar(SK_AC *pAC, SK_IOC IoC, SK_U32 Id, void* pBuf,
unsigned int* pLen, SK_U32 Instance, SK_U32 NetIndex);
extern int SkPnmiPreSetVar(SK_AC *pAC, SK_IOC IoC, SK_U32 Id,
void* pBuf, unsigned int *pLen, SK_U32 Instance, SK_U32 NetIndex);
extern int SkPnmiSetVar(SK_AC *pAC, SK_IOC IoC, SK_U32 Id, void* pBuf,
unsigned int *pLen, SK_U32 Instance, SK_U32 NetIndex);
extern int SkPnmiGetStruct(SK_AC *pAC, SK_IOC IoC, void* pBuf,
Expand Down
1 change: 0 additions & 1 deletion drivers/net/sk98lin/h/skgesirq.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@

extern void SkGeSirqIsr(SK_AC *pAC, SK_IOC IoC, SK_U32 Istatus);
extern int SkGeSirqEvent(SK_AC *pAC, SK_IOC IoC, SK_U32 Event, SK_EVPARA Para);
extern void SkHWLinkUp(SK_AC *pAC, SK_IOC IoC, int Port);
extern void SkHWLinkDown(SK_AC *pAC, SK_IOC IoC, int Port);

#endif /* _INC_SKGESIRQ_H_ */
3 changes: 0 additions & 3 deletions drivers/net/sk98lin/h/ski2c.h
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ typedef struct s_I2c {
} SK_I2C;

extern int SkI2cInit(SK_AC *pAC, SK_IOC IoC, int Level);
extern int SkI2cWrite(SK_AC *pAC, SK_IOC IoC, SK_U32 Data, int Dev, int Size,
int Reg, int Burst);
extern int SkI2cReadSensor(SK_AC *pAC, SK_IOC IoC, SK_SENSOR *pSen);
#ifdef SK_DIAG
extern SK_U32 SkI2cRead(SK_AC *pAC, SK_IOC IoC, int Dev, int Size, int Reg,
int Burst);
Expand Down
15 changes: 0 additions & 15 deletions drivers/net/sk98lin/h/skvpd.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,6 @@ extern SK_U32 VpdReadDWord(
int addr);
#endif /* SKDIAG */

extern int VpdSetupPara(
SK_AC *pAC,
const char *key,
const char *buf,
int len,
int type,
int op);

extern SK_VPD_STATUS *VpdStat(
SK_AC *pAC,
SK_IOC IoC);
Expand Down Expand Up @@ -227,11 +219,6 @@ extern int VpdUpdate(
SK_AC *pAC,
SK_IOC IoC);

extern void VpdErrLog(
SK_AC *pAC,
SK_IOC IoC,
char *msg);

#ifdef SKDIAG
extern int VpdReadBlock(
SK_AC *pAC,
Expand All @@ -249,15 +236,13 @@ extern int VpdWriteBlock(
#endif /* SKDIAG */
#else /* SK_KR_PROTO */
extern SK_U32 VpdReadDWord();
extern int VpdSetupPara();
extern SK_VPD_STATUS *VpdStat();
extern int VpdKeys();
extern int VpdRead();
extern SK_BOOL VpdMayWrite();
extern int VpdWrite();
extern int VpdDelete();
extern int VpdUpdate();
extern void VpdErrLog();
#endif /* SK_KR_PROTO */

#endif /* __INC_SKVPD_H_ */
Loading

0 comments on commit e03d72b

Please sign in to comment.