Skip to content

Commit

Permalink
ath6kl: Remove endpoint reference from hif_scatter_req
Browse files Browse the repository at this point in the history
Endpoint id ffrom htc_packet can be used instead.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
  • Loading branch information
Vasanthakumar Thiagarajan authored and Kalle Valo committed Aug 9, 2011
1 parent 7c565b6 commit e041c7f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
3 changes: 1 addition & 2 deletions drivers/net/wireless/ath/ath6kl/hif.h
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,8 @@ struct hif_scatter_req {
/* total length of entire transfer */
u32 len;

void (*complete) (struct hif_scatter_req *);
void (*complete) (struct htc_target *, struct hif_scatter_req *);
int status;
struct htc_endpoint *ep;
int scat_entries;

struct bus_request *busrequest;
Expand Down
10 changes: 6 additions & 4 deletions drivers/net/wireless/ath/ath6kl/htc.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ static void htc_tx_comp_handler(struct htc_target *target,
htc_tx_complete(endpoint, &container);
}

static void htc_async_tx_scat_complete(struct hif_scatter_req *scat_req)
static void htc_async_tx_scat_complete(struct htc_target *target,
struct hif_scatter_req *scat_req)
{
struct htc_endpoint *endpoint = scat_req->ep;
struct htc_target *target = endpoint->target;
struct htc_endpoint *endpoint;
struct htc_packet *packet;
struct list_head tx_compq;
int i;
Expand All @@ -144,6 +144,9 @@ static void htc_async_tx_scat_complete(struct hif_scatter_req *scat_req)
if (scat_req->status)
ath6kl_err("send scatter req failed: %d\n", scat_req->status);

packet = scat_req->scat_list[0].packet;
endpoint = &target->endpoint[packet->endpoint];

/* walk through the scatter list and process */
for (i = 0; i < scat_req->scat_entries; i++) {
packet = scat_req->scat_list[i].packet;
Expand Down Expand Up @@ -465,7 +468,6 @@ static void htc_issue_send_bundle(struct htc_endpoint *endpoint,

/* send path is always asynchronous */
scat_req->complete = htc_async_tx_scat_complete;
scat_req->ep = endpoint;
n_sent_bundle++;
tot_pkts_bundle += scat_req->scat_entries;

Expand Down
6 changes: 3 additions & 3 deletions drivers/net/wireless/ath/ath6kl/htc_hif.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ static void ath6kldev_rw_async_handler(struct htc_target *target,

ath6kl_add_io_pkt(dev, packet);

req->complete(req);
req->complete(target, req);
}

static int ath6kldev_rw_scatter(struct ath6kl *ar, struct hif_scatter_req *req)
Expand Down Expand Up @@ -243,7 +243,7 @@ static int ath6kldev_rw_scatter(struct ath6kl *ar, struct hif_scatter_req *req)
if (packet != NULL)
ath6kl_add_io_pkt(dev, packet);
req->status = status;
req->complete(req);
req->complete(ar->htc_target, req);
status = 0;
}

Expand Down Expand Up @@ -279,7 +279,7 @@ int ath6kldev_submit_scat_req(struct ath6kl_device *dev,
if (status) {
if (!read) {
scat_req->status = status;
scat_req->complete(scat_req);
scat_req->complete(dev->ar->htc_target, scat_req);
return 0;
}
return status;
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath6kl/sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ static int ath6kl_sdio_scat_rw(struct ath6kl_sdio *ar_sdio,
scat_req->status);

if (scat_req->req & HIF_ASYNCHRONOUS)
scat_req->complete(scat_req);
scat_req->complete(ar_sdio->ar->htc_target, scat_req);

return status;
}
Expand Down

0 comments on commit e041c7f

Please sign in to comment.