Skip to content

Commit

Permalink
staging/lustre/llite: A not locked mutex can be unlocked.
Browse files Browse the repository at this point in the history
In case of memory pressure a not locked mutex can be unlocked
in function ll_file_open(). This is not allowed and subsequent
behavior is not defined.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3157
Lustre-change: http://review.whamcloud.com/6028
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John Hammond <johnlockwoodhammond@gmail.com>
Reviewed-by: Nikitas Angelinas <nikitas_angelinas@xyratex.com>
Reviewed-by: Sebastien Buisson <sebastien.buisson@bull.net>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <tao.peng@emc.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dmitry Eremin authored and Greg Kroah-Hartman committed Jul 23, 2013
1 parent 73863d8 commit e06c9df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/staging/lustre/lustre/llite/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ int ll_file_open(struct inode *inode, struct file *file)

fd = ll_file_data_get();
if (fd == NULL)
GOTO(out_och_free, rc = -ENOMEM);
GOTO(out_openerr, rc = -ENOMEM);

fd->fd_file = file;
if (S_ISDIR(inode->i_mode)) {
Expand Down

0 comments on commit e06c9df

Please sign in to comment.