Skip to content

Commit

Permalink
sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll()
Browse files Browse the repository at this point in the history
efx_mcdi_poll() uses positive error numbers, matching the MCDI
protocol.  It must negate the result of efx_mcdi_poll_reboot() which
returns the usual negative error numbers.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ben Hutchings authored and David S. Miller committed Feb 19, 2010
1 parent b8afe64 commit e0bf54c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sfc/mcdi.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ static int efx_mcdi_poll(struct efx_nic *efx)
efx_dword_t reg;

/* Check for a reboot atomically with respect to efx_mcdi_copyout() */
rc = efx_mcdi_poll_reboot(efx);
rc = -efx_mcdi_poll_reboot(efx);
if (rc)
goto out;

Expand Down

0 comments on commit e0bf54c

Please sign in to comment.