Skip to content

Commit

Permalink
drm/bochs: Remove unecessary NULL check in gem_free
Browse files Browse the repository at this point in the history
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Noticed while chasing coverity reports, somehow this one here was not
flagged.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Apr 22, 2014
1 parent dcb1ee5 commit e0c6a73
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/gpu/drm/bochs/bochs_mm.c
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,6 @@ void bochs_gem_free_object(struct drm_gem_object *obj)
{
struct bochs_bo *bochs_bo = gem_to_bochs_bo(obj);

if (!bochs_bo)
return;
bochs_bo_unref(&bochs_bo);
}

Expand Down

0 comments on commit e0c6a73

Please sign in to comment.