Skip to content

Commit

Permalink
sfc: Fix memory BAR release call on error path
Browse files Browse the repository at this point in the history
Match pci_request_region() with pci_release_region(), not
release_mem_region().

From: Steve Hodgson <shodgson@solarflare.com>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Ben Hutchings authored and Jeff Garzik committed Sep 24, 2008
1 parent 88c5942 commit e1074a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sfc/efx.c
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ static int efx_init_io(struct efx_nic *efx)
return 0;

fail4:
release_mem_region(efx->membase_phys, efx->type->mem_map_size);
pci_release_region(efx->pci_dev, efx->type->mem_bar);
fail3:
efx->membase_phys = 0;
fail2:
Expand Down

0 comments on commit e1074a0

Please sign in to comment.