Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 122362
b: refs/heads/master
c: 511061e
h: refs/heads/master
v: v3
  • Loading branch information
Alexey Dobriyan authored and Patrick McHardy committed Nov 4, 2008
1 parent fa2f5eb commit e10e5e1
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 19223f26d97077da8cf25251458afe00cae20cbb
refs/heads/master: 511061e2dd1b84bb21bb97c9216a19606c29ac02
2 changes: 1 addition & 1 deletion trunk/include/linux/netfilter_bridge/ebtables.h
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ struct ebt_table

#define EBT_ALIGN(s) (((s) + (__alignof__(struct ebt_replace)-1)) & \
~(__alignof__(struct ebt_replace)-1))
extern int ebt_register_table(struct ebt_table *table);
extern int ebt_register_table(struct net *net, struct ebt_table *table);
extern void ebt_unregister_table(struct ebt_table *table);
extern unsigned int ebt_do_table(unsigned int hook, struct sk_buff *skb,
const struct net_device *in, const struct net_device *out,
Expand Down
2 changes: 1 addition & 1 deletion trunk/net/bridge/netfilter/ebtable_broute.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ static int __init ebtable_broute_init(void)
{
int ret;

ret = ebt_register_table(&broute_table);
ret = ebt_register_table(&init_net, &broute_table);
if (ret < 0)
return ret;
/* see br_input.c */
Expand Down
2 changes: 1 addition & 1 deletion trunk/net/bridge/netfilter/ebtable_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ static int __init ebtable_filter_init(void)
{
int ret;

ret = ebt_register_table(&frame_filter);
ret = ebt_register_table(&init_net, &frame_filter);
if (ret < 0)
return ret;
ret = nf_register_hooks(ebt_ops_filter, ARRAY_SIZE(ebt_ops_filter));
Expand Down
2 changes: 1 addition & 1 deletion trunk/net/bridge/netfilter/ebtable_nat.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ static int __init ebtable_nat_init(void)
{
int ret;

ret = ebt_register_table(&frame_nat);
ret = ebt_register_table(&init_net, &frame_nat);
if (ret < 0)
return ret;
ret = nf_register_hooks(ebt_ops_nat, ARRAY_SIZE(ebt_ops_nat));
Expand Down
27 changes: 14 additions & 13 deletions trunk/net/bridge/netfilter/ebtables.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@


static DEFINE_MUTEX(ebt_mutex);
static LIST_HEAD(ebt_tables);

static struct xt_target ebt_standard_target = {
.name = "standard",
Expand Down Expand Up @@ -315,9 +314,11 @@ find_inlist_lock(struct list_head *head, const char *name, const char *prefix,
}

static inline struct ebt_table *
find_table_lock(const char *name, int *error, struct mutex *mutex)
find_table_lock(struct net *net, const char *name, int *error,
struct mutex *mutex)
{
return find_inlist_lock(&ebt_tables, name, "ebtable_", error, mutex);
return find_inlist_lock(&net->xt.tables[NFPROTO_BRIDGE], name,
"ebtable_", error, mutex);
}

static inline int
Expand Down Expand Up @@ -944,7 +945,7 @@ static void get_counters(struct ebt_counter *oldcounters,
}

/* replace the table */
static int do_replace(void __user *user, unsigned int len)
static int do_replace(struct net *net, void __user *user, unsigned int len)
{
int ret, i, countersize;
struct ebt_table_info *newinfo;
Expand Down Expand Up @@ -1016,7 +1017,7 @@ static int do_replace(void __user *user, unsigned int len)
if (ret != 0)
goto free_counterstmp;

t = find_table_lock(tmp.name, &ret, &ebt_mutex);
t = find_table_lock(net, tmp.name, &ret, &ebt_mutex);
if (!t) {
ret = -ENOENT;
goto free_iterate;
Expand Down Expand Up @@ -1097,7 +1098,7 @@ static int do_replace(void __user *user, unsigned int len)
return ret;
}

int ebt_register_table(struct ebt_table *table)
int ebt_register_table(struct net *net, struct ebt_table *table)
{
struct ebt_table_info *newinfo;
struct ebt_table *t;
Expand Down Expand Up @@ -1157,7 +1158,7 @@ int ebt_register_table(struct ebt_table *table)
if (ret != 0)
goto free_chainstack;

list_for_each_entry(t, &ebt_tables, list) {
list_for_each_entry(t, &net->xt.tables[NFPROTO_BRIDGE], list) {
if (strcmp(t->name, table->name) == 0) {
ret = -EEXIST;
BUGPRINT("Table name already exists\n");
Expand All @@ -1170,7 +1171,7 @@ int ebt_register_table(struct ebt_table *table)
ret = -ENOENT;
goto free_unlock;
}
list_add(&table->list, &ebt_tables);
list_add(&table->list, &net->xt.tables[NFPROTO_BRIDGE]);
mutex_unlock(&ebt_mutex);
return 0;
free_unlock:
Expand Down Expand Up @@ -1208,7 +1209,7 @@ void ebt_unregister_table(struct ebt_table *table)
}

/* userspace just supplied us with counters */
static int update_counters(void __user *user, unsigned int len)
static int update_counters(struct net *net, void __user *user, unsigned int len)
{
int i, ret;
struct ebt_counter *tmp;
Expand All @@ -1228,7 +1229,7 @@ static int update_counters(void __user *user, unsigned int len)
return -ENOMEM;
}

t = find_table_lock(hlp.name, &ret, &ebt_mutex);
t = find_table_lock(net, hlp.name, &ret, &ebt_mutex);
if (!t)
goto free_tmp;

Expand Down Expand Up @@ -1386,10 +1387,10 @@ static int do_ebt_set_ctl(struct sock *sk,

switch(cmd) {
case EBT_SO_SET_ENTRIES:
ret = do_replace(user, len);
ret = do_replace(sock_net(sk), user, len);
break;
case EBT_SO_SET_COUNTERS:
ret = update_counters(user, len);
ret = update_counters(sock_net(sk), user, len);
break;
default:
ret = -EINVAL;
Expand All @@ -1406,7 +1407,7 @@ static int do_ebt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len)
if (copy_from_user(&tmp, user, sizeof(tmp)))
return -EFAULT;

t = find_table_lock(tmp.name, &ret, &ebt_mutex);
t = find_table_lock(sock_net(sk), tmp.name, &ret, &ebt_mutex);
if (!t)
return ret;

Expand Down

0 comments on commit e10e5e1

Please sign in to comment.