---

yaml --- r: 187090 b: refs/heads/master c: f8d4f61 h: refs/heads/master v: v3
git-mirror · Mar 8, 2010 · e14112c · e14112c
1 parent c68a766
commit e14112c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: b35c74dab64f4c212f36d868419108556c9cf3e2
+refs/heads/master: f8d4f618fed5a4978afada52166bc2efaf7656d1
diff --git a/trunk/fs/sysfs/inode.c b/trunk/fs/sysfs/inode.c
@@ -111,20 +111,20 @@ int sysfs_setattr(struct dentry *dentry, struct iattr *iattr)
 	if (!sd)
 		return -EINVAL;
 
+	mutex_lock(&sysfs_mutex);
 	error = inode_change_ok(inode, iattr);
 	if (error)
-		return error;
+		goto out;
 
 	iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */
 
 	error = inode_setattr(inode, iattr);
 	if (error)
-		return error;
+		goto out;
 
-	mutex_lock(&sysfs_mutex);
 	error = sysfs_sd_setattr(sd, iattr);
+out:
 	mutex_unlock(&sysfs_mutex);
-
 	return error;
 }