Skip to content

Commit

Permalink
net: natsemi: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Oct 21, 2013
1 parent ecb22e1 commit e146aaa
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/natsemi/natsemi.c
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,6 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)

err_ioremap:
pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);

err_pci_request_regions:
free_netdev(dev);
Expand Down Expand Up @@ -3220,7 +3219,6 @@ static void natsemi_remove1(struct pci_dev *pdev)
pci_release_regions (pdev);
iounmap(ioaddr);
free_netdev (dev);
pci_set_drvdata(pdev, NULL);
}

#ifdef CONFIG_PM
Expand Down

0 comments on commit e146aaa

Please sign in to comment.