Skip to content

Commit

Permalink
[SELinux]: Fix double free in selinux_netlbl_sock_setsid()
Browse files Browse the repository at this point in the history
As pointed out by Adrian Bunk, commit
45c950e ("fix memory leak in netlabel
code") caused a double-free when security_netlbl_sid_to_secattr()
fails.  This patch fixes this by removing the netlbl_secattr_destroy()
call from that function since we are already releasing the secattr
memory in selinux_netlbl_sock_setsid().

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Paul Moore authored and David S. Miller committed Feb 1, 2008
1 parent 1a6509d commit e1770d9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion security/selinux/ss/services.c
Original file line number Diff line number Diff line change
Expand Up @@ -2692,7 +2692,6 @@ int security_netlbl_sid_to_secattr(u32 sid, struct netlbl_lsm_secattr *secattr)

netlbl_sid_to_secattr_failure:
POLICY_RDUNLOCK;
netlbl_secattr_destroy(secattr);
return rc;
}
#endif /* CONFIG_NETLABEL */

0 comments on commit e1770d9

Please sign in to comment.