Skip to content

Commit

Permalink
perf symbols: Fix inverted logic for showing kallsyms as the source o…
Browse files Browse the repository at this point in the history
…f symbols

Only if we parsed /proc/kallsyms (or a copy found in the buildid
cache) we should set the dso long name to "[kernel.kallsyms]".

Reported-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1264178102-4203-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Jan 27, 2010
1 parent 0f35cd4 commit e1c7c6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,7 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map,
out_try_fixup:
if (err > 0) {
out_fixup:
if (kallsyms_filename == NULL)
if (kallsyms_filename != NULL)
dso__set_long_name(self, strdup("[kernel.kallsyms]"));
map__fixup_start(map);
map__fixup_end(map);
Expand Down

0 comments on commit e1c7c6a

Please sign in to comment.